WIP Convert to ts #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 8, 2021 14:23
Given a standard .gitattributes file (just added in previous commit)
after doing a fresh clone of this repo on mac with vanilla git v2.32.0,
git status shows:
modified: package-lock.json
modified: package.json
$ git diff
warning: CRLF will be replaced by LF in package-lock.json.
warning: CRLF will be replaced by LF in package.json.
diff --git a/package-lock.json b/package-lock.json
Binary files a/package-lock.json and b/package-lock.json differ
diff --git a/package.json b/package.json
-{
- "name": "solid-todomvc",
...
Seems like best practice is to add this to your global ~/.gitconfig:
[core]
attributesfile = ~/.gitattributes_global
Co-authored-by: ts-migrate <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot of work/cleanup to do here still. Just wanted to share WIP as I may not get back to this for a few weekends.
I was having a time with the types, so started inling all the functions, so see what the natural types are, convert/type case values to something better, than pass pure data into utility functions
Most recent commit is going to be the most interesting
Probably this should live along side some JS version, since likely whatever I come up with will be extra "typescript-y"