forked from ethereum-optimism/superchain-ops
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Folder Structure for Example Tasks #26
Draft
ElliotFriedman
wants to merge
12
commits into
chore/remove-constants-file
Choose a base branch
from
chore/directory-cleanup
base: chore/remove-constants-file
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Change Folder Structure for Example Tasks #26
ElliotFriedman
wants to merge
12
commits into
chore/remove-constants-file
from
chore/directory-cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: compiler error in task eth/029 * fix: simulate_nested.
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
* perf: refactors to allow compiling without via-ir * style: switch to // for non-natspec comments * fix: skip rehearsal 1 in CI for now
I think we can keep the templates folder in |
* update upstream forge-std to include new StdChains Signed-off-by: Elliot <[email protected]> * stop using Constants.sol, instead use StdChains to fetch chain ids Signed-off-by: Elliot <[email protected]> * remove constants.sol Signed-off-by: Elliot <[email protected]> * fmt Signed-off-by: Elliot <[email protected]> --------- Signed-off-by: Elliot <[email protected]>
* tenderly simulation * remove useNonce variable in favor of inlining function call Signed-off-by: Elliot <[email protected]> --------- Signed-off-by: Elliot <[email protected]> Co-authored-by: Elliot <[email protected]> Co-authored-by: Elliot <[email protected]>
* feat: Remove CI Builder & add mise dependency * fix: Adding go to mise. * fix: checkout with mise for the simulate commands. * fix: reduce build time PR merged and rebased.
* add execution test for single multisig * add execution test for nested multisig * check execTransaction success status * fix stack too deep errors Signed-off-by: Elliot <[email protected]> * add storage offset constants Signed-off-by: Elliot <[email protected]> * add threshold assertion Signed-off-by: Elliot <[email protected]> * assert threshold is updated Signed-off-by: Elliot <[email protected]> --------- Signed-off-by: Elliot <[email protected]> Co-authored-by: Elliot <[email protected]> Co-authored-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close ethereum-optimism#519