Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Folder Structure for Example Tasks #26

Draft
wants to merge 12 commits into
base: chore/remove-constants-file
Choose a base branch
from

Conversation

ElliotFriedman
Copy link

Should close ethereum-optimism#519

blmalone and others added 4 commits January 31, 2025 23:35
* fix: compiler error in task eth/029

* fix: simulate_nested.
* perf: refactors to allow compiling without via-ir

* style: switch to // for non-natspec comments

* fix: skip rehearsal 1 in CI for now
@prateek105
Copy link
Collaborator

I think we can keep the templates folder in src/fps, as I think all of these templates based tasks will be there in the future as well. @blmalone what do u think?

ElliotFriedman and others added 8 commits February 3, 2025 17:10
* update upstream forge-std to include new StdChains

Signed-off-by: Elliot <[email protected]>

* stop using Constants.sol, instead use StdChains to fetch chain ids

Signed-off-by: Elliot <[email protected]>

* remove constants.sol

Signed-off-by: Elliot <[email protected]>

* fmt

Signed-off-by: Elliot <[email protected]>

---------

Signed-off-by: Elliot <[email protected]>
* tenderly simulation

* remove useNonce variable in favor of inlining function call

Signed-off-by: Elliot <[email protected]>

---------

Signed-off-by: Elliot <[email protected]>
Co-authored-by: Elliot <[email protected]>
Co-authored-by: Elliot <[email protected]>
* feat: Remove CI Builder & add mise dependency

* fix: Adding go to mise.

* fix: checkout with mise for the simulate commands.

* fix: reduce build time PR merged and rebased.
* add execution test for single multisig

* add execution test for nested multisig

* check execTransaction success status

* fix stack too deep errors

Signed-off-by: Elliot <[email protected]>

* add storage offset constants

Signed-off-by: Elliot <[email protected]>

* add threshold assertion

Signed-off-by: Elliot <[email protected]>

* assert threshold is updated

Signed-off-by: Elliot <[email protected]>

---------

Signed-off-by: Elliot <[email protected]>
Co-authored-by: Elliot <[email protected]>
Co-authored-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants