simulate and test non terminal tasks #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking great! Can you add this into the CI tests? |
|
Can you please provide a PR description here to outline what feature is being built? Additionally, there don't seem to be any docs describing how to use this feature in the PR. Ideally I can read something and easily understand what's being built. |
blmalone
reviewed
Jan 17, 2025
…ereum-optimism#476) * upgrade Base's SystemConfig to v2.3.0 * comment simulate w/o ledger * add explicit comment for gasLimit override * mark as ready to sign * push codeExceptions exceptions into HoloceneSystemConfigUpgrade contract (ethereum-optimism#478) Some ready but not-yet-executed tasks depend on this contract, but they are simulated in CI so if that is green should be OK. * add Tx 4 overview * add context for extra tx * remove mainnet task specific logic * remove mainnet task specific logic * remove .env comment * impl nits feedback * add cast td hints * add storage layout link * add more context for tx 4 * format VALIDATION.md and delete OVERVIEW.md * fix validation formatting * update validation to mention previous startBlock value * update README.md --------- Co-authored-by: George Knee <[email protected]> Co-authored-by: Matt Solomon <[email protected]>
* remove: name and description from task config Signed-off-by: Elliot <[email protected]> add example task template config files Signed-off-by: Elliot <[email protected]> add fps example templates Signed-off-by: Elliot <[email protected]> remove name and description, set task nonce to current multisig nonce Signed-off-by: Elliot <[email protected]> fmt and add TODO to switch to manual nonce later Signed-off-by: Elliot <[email protected]> templates Signed-off-by: Elliot <[email protected]> remove safeNonce from mock network config Signed-off-by: Elliot <[email protected]> * checkpoint Signed-off-by: Elliot <[email protected]> * remove isNested flag from toml config file Signed-off-by: Elliot <[email protected]> * fmt Signed-off-by: Elliot <[email protected]> * fix is nested safe logic * fix task01 * add Task02 * refactor _getDataToSign function Signed-off-by: Elliot <[email protected]> * add: gas template docs Signed-off-by: Elliot <[email protected]> * add: template examples to run Signed-off-by: Elliot <[email protected]> * add: error handle parsing l2 chain configs Signed-off-by: Elliot <[email protected]> * fmt Signed-off-by: Elliot <[email protected]> * remove unused variable name Signed-off-by: Elliot <[email protected]> * error handle reading in and parsing task config file Signed-off-by: Elliot <[email protected]> * add breakdown of calldata difference for signers Signed-off-by: Elliot <[email protected]> * remove setting scalars to simplify example task Signed-off-by: Elliot <[email protected]> * add duplicate call structure of task 020 in existing tooling Signed-off-by: Elliot <[email protected]> * remove setting gas scalars from gas config template Signed-off-by: Elliot <[email protected]> * note on commenting out failing check and link to diffchecker Signed-off-by: Elliot <[email protected]> * add: task config tests Signed-off-by: Elliot <[email protected]> * add forge build before running template Signed-off-by: Elliot <[email protected]> * update docs to only include gas limits and not gas scalars Signed-off-by: Elliot <[email protected]> * remove template ci runs Signed-off-by: Elliot <[email protected]> * Update src/fps/FPS.md Co-authored-by: blaine <[email protected]> * Update src/fps/FPS.md Co-authored-by: blaine <[email protected]> * Update src/fps/FPS.md * fps -> new task simulation tooling Signed-off-by: Elliot <[email protected]> * remove unused template files Signed-off-by: Elliot <[email protected]> * naming: fps.md -> readme.md Signed-off-by: Elliot <[email protected]> * naming: move away from fps Signed-off-by: Elliot <[email protected]> * use op types, remove inlined interfaces Signed-off-by: Elliot <[email protected]> * update readme for running tasks Signed-off-by: Elliot <[email protected]> * update: cleanup, make MultisigTask a generic template Signed-off-by: Elliot <[email protected]> * fix test Signed-off-by: Elliot <[email protected]> * delete: task config Signed-off-by: Elliot <[email protected]> * update based on PR feedback, remove taskConfig.toml fields, and safeNonce and isNestedSafe Signed-off-by: Elliot <[email protected]> * remove unused mock network configs Signed-off-by: Elliot <[email protected]> * remove opmainnetConfig.toml Signed-off-by: Elliot <[email protected]> * add op set gas limit config Signed-off-by: Elliot <[email protected]> * update command to use new run function Signed-off-by: Elliot <[email protected]> * update command to only have mainnet config toml file Signed-off-by: Elliot <[email protected]> * naming: networkConfigFilePath -> taskConfigFilePath Signed-off-by: Elliot <[email protected]> * fmt Signed-off-by: Elliot <[email protected]> * natspec, taskStorageWrites -> _taskStorageWrites Signed-off-by: Elliot <[email protected]> * fix test Signed-off-by: Elliot <[email protected]> * add additional docs for address registry Signed-off-by: Elliot <[email protected]> * fix: nested multisig issue Signed-off-by: Elliot <[email protected]> * add op gas config command Signed-off-by: Elliot <[email protected]> * add task tests * Revert "add task tests" This reverts commit 70ed74f. * fix: nonce for nested safes use their own nonce and not parent Signed-off-by: Elliot <[email protected]> * update natspec proposal -> task Signed-off-by: Elliot <[email protected]> --------- Signed-off-by: Elliot <[email protected]> Co-authored-by: prateek <[email protected]> Co-authored-by: blaine <[email protected]>
prateek105
force-pushed
the
feat/task-runner
branch
from
d0eb5e4 to
d5d26b7
Compare
* naming: proposal -> task Signed-off-by: Elliot <[email protected]> * naming: proposal -> task Signed-off-by: Elliot <[email protected]> --------- Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
prateek105
force-pushed
the
feat/task-runner
branch
from
d5d26b7 to
b71fb73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows integration tests from the monorepo to be run after the state changes are applied from a non terminal task to a local fork.
There was no clean way to apply the simulation to an anvil fork without doing a dry run first, then taking the state diff from the dry run, applying it to a network, and then running the integration tests.