This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Uses purge_all_bank_snapshots() #35380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -344,7 +344,7 @@ fn bank_forks_from_snapshot( | |||
| // snapshot expects. This would cause the node to crash again. To prevent that, purge all | |||
| // the bank snapshots here. In the above scenario, this will cause the node to load from a | |||
| // snapshot archive next time, which is safe. | |||
| snapshot_utils::purge_old_bank_snapshots(&snapshot_config.bank_snapshots_dir, 0, None); | |||
| snapshot_utils::purge_all_bank_snapshots(&snapshot_config.bank_snapshots_dir); | |||
There was a problem hiding this comment.
does it matter we don't sort now?
I think now. just confirming.
There was a problem hiding this comment.
Correct, we do not need to sort. That was one of the justifications for #35291, was to remove the sort.
|
@apfitzge We're dog-fooding trying out requiring 2+ approvals on PRs. So I'm going to wait for your approval before merging. No rush, just letting you know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #35350 purges all bank snapshots after fastboot. It's implementation originally used
purge_all_bank_snapshots(), a la #35291, but the impl was changed to make backporting to v1.18 easy.This PR exists to update master back to the new function.
Summary of Changes
Use
purge_all_bank_snapshots().