Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Set slot and env in tx batch specific cache #35377

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Feb 29, 2024

Problem

The transaction batch specific cache sometimes doesn't have the slot and environment set correctly. It's currently not a problem, as it's missing during error scenario, and is never used. But, for future proofing, it should be correctly set.

Summary of Changes

Set the slot and environment in the returned cache object.

Fixes #

@pgarg66 pgarg66 marked this pull request as ready for review February 29, 2024 17:51
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.7%. Comparing base (6ee3bb9) to head (b9fc4f5).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #35377    +/-   ##
========================================
  Coverage    81.7%    81.7%            
========================================
  Files         834      834            
  Lines      224299   224818   +519     
========================================
+ Hits       183361   183862   +501     
- Misses      40938    40956    +18     

@pgarg66 pgarg66 merged commit 7399178 into solana-labs:master Mar 1, 2024
35 checks passed
@pgarg66 pgarg66 deleted the set-slot-env branch March 1, 2024 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants