Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Inlined dependencies must live in devDependencies so that they don't appear as dependencies in the published package #3676

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Inlined dependencies must live in devDependencies so that they don't appear as dependencies in the published package #3676

merged 1 commit into from
Dec 5, 2024
+37 −28

Conversation

steveluscher
Copy link
Contributor

These, after all, don't exist on npm.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f5407b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Dec 5, 2024 — with Graphite App
@steveluscher Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@steveluscher
Inlined dependencies must live in devDependencies so that they don'…
f5407b9 
…t appear as dependencies in the published package
@steveluscher steveluscher force-pushed the 12-05-inlined_dependencies_must_live_in_devdependencies_so_that_they_don_t_appear_as_dependencies_in_the_published_package branch from 16d3d34 to f5407b9 Compare December 5, 2024 03:51
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

Automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 5, 2024
@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Dec 5, 2024 — with Graphite App
@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 5, 2024

BundleMon

Unchanged files (127)
Status Path Size Limits
✅ @solana/web3.js production bundle
library/dist/index.production.min.js
 33.81KB -
✅ rpc-graphql/dist/index.browser.mjs
 18.76KB -
✅ rpc-graphql/dist/index.native.mjs
 18.75KB -
✅ rpc-graphql/dist/index.node.mjs
 18.75KB -
✅ errors/dist/index.node.mjs
 14KB -
✅ errors/dist/index.browser.mjs
 13.99KB -
✅ errors/dist/index.native.mjs
 13.98KB -
✅ transaction-messages/dist/index.browser.mjs
 7.05KB -
✅ transaction-messages/dist/index.native.mjs
 7.05KB -
✅ transaction-messages/dist/index.node.mjs
 7.05KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.49KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.47KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.45KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.92KB -
✅ rpc-transformers/dist/index.native.mjs
 2.92KB -
✅ rpc-transformers/dist/index.node.mjs
 2.92KB -
✅ addresses/dist/index.browser.mjs
 2.8KB -
✅ addresses/dist/index.native.mjs
 2.8KB -
✅ addresses/dist/index.node.mjs
 2.8KB -
✅ library/dist/index.browser.mjs
 2.67KB -
✅ library/dist/index.native.mjs
 2.67KB -
✅ library/dist/index.node.mjs
 2.67KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ signers/dist/index.browser.mjs
 2.53KB -
✅ signers/dist/index.native.mjs
 2.53KB -
✅ signers/dist/index.node.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.46KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.4KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ sysvars/dist/index.browser.mjs
 2.25KB -
✅ sysvars/dist/index.native.mjs
 2.25KB -
✅ sysvars/dist/index.node.mjs
 2.24KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.08KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.08KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ transactions/dist/index.browser.mjs
 1.99KB -
✅ transactions/dist/index.native.mjs
 1.99KB -
✅ transactions/dist/index.node.mjs
 1.99KB -
✅ react/dist/index.native.mjs
 1.98KB -
✅ react/dist/index.browser.mjs
 1.98KB -
✅ react/dist/index.node.mjs
 1.98KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ keys/dist/index.browser.mjs
 1.86KB -
✅ keys/dist/index.native.mjs
 1.86KB -
✅ keys/dist/index.node.mjs
 1.85KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.75KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-types/dist/index.browser.mjs
 1.6KB -
✅ rpc-types/dist/index.native.mjs
 1.6KB -
✅ rpc-types/dist/index.node.mjs
 1.6KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-api/dist/index.node.mjs
 960B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 829B -
✅ rpc-spec/dist/index.native.mjs
 829B -
✅ rpc-spec/dist/index.node.mjs
 828B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 790B -
✅ instructions/dist/index.browser.mjs
 771B -
✅ instructions/dist/index.native.mjs
 770B -
✅ instructions/dist/index.node.mjs
 768B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.browser.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ fast-stable-stringify/dist/index.native.mjs
 723B -
✅ fast-stable-stringify/dist/index.node.mjs
 722B -
✅ compat/dist/index.browser.mjs
 712B -
✅ compat/dist/index.native.mjs
 711B -
✅ compat/dist/index.node.mjs
 710B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 233B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ crypto-impl/dist/index.node.mjs
 114B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

A preview of the GitHub Pages site based on this PR is now available here:

solana-labs.github.io/solana-web3.js-pr-preview/3676/

@mergify mergify bot merged commit 6ae441e into master Dec 5, 2024
14 checks passed
@mergify mergify bot deleted the 12-05-inlined_dependencies_must_live_in_devdependencies_so_that_they_don_t_appear_as_dependencies_in_the_published_package branch December 5, 2024 04:04
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steveluscher