Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

chore: upgrade hash32 and silence miri false positive #618

Closed

Conversation

0xalpharush
Copy link

The current version of hash32 is about a year older than the one most recently released and has some behavior that is (incorrectly) flagged as undefined behavior (UB) by tools like Miri. This prevents any tool downstream of rbpf from using the rustc flags and tools like miri to identify UB as it will fail (xref rust-embedded-community/hash32#14).

$ RUSTFLAGS="-Zstrict-init-checks" cargo +nightly test
thread 'elf::test::test_entrypoint' panicked at core/src/panicking.rs:221:5:
attempted to leave type `murmur3::Buffer` uninitialized, which is invalid
thread caused non-unwinding panic. aborting.

Upgrading hash32 fixes this.

@Lichtso
Copy link

Lichtso commented Dec 12, 2024

Thank you for the contribution! This repository is no longer in use. Please re-open this pull request in the sbpf repo: https://github.com/anza-xyz/sbpf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants