This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Refactor - Make declare_builtin_function receive a generic ContextObject
#616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro
declare_builtin_functionunnecessarily requires a coded type that implements the traitContextObject. Alternatively, we can modify the macro to accept a generic type that implements the trait.The idea behind this change is to use the macro for creating a tombstone function for static syscalls when they are deactivated behind a feature gate. Having the generic type allows the tombstone to work with Agave's
InvokeContexttype.