Add missing smart wallet (PDA wallet) support #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@valentinmadrid is attempting to deploy a commit to the blockworks-foundation Team on Vercel. A member of the Team first needs to authorize it. |
asktree
reviewed
Nov 14, 2023
|
|
||
| const programVersion = await fetchProgramVersion(connection, realm.owner) | ||
|
|
||
| if (wallet?.name == "SquadsX") { |
There was a problem hiding this comment.
could you explain this and why a special case is needed? and if it really is needed, please leave comments in the code about it
There was a problem hiding this comment.
Added comments.
asktree
reviewed
Nov 14, 2023
| let transferAuthority; | ||
|
|
||
| // Checks if the connected wallet is the Squads Multisig extension. This wallet needs custom logic as ephemeral Keypair signatures can not be used after the transaction blockhash has expired. | ||
| if (wallet?.name == "SquadsX") { |
There was a problem hiding this comment.
style: just use a ternary please!
asktree
reviewed
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds allowOwnerOffCurve to ATA derivations for Realms to be compatible with the SquadsX extension.