Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMD-0231: Disable account rent epoch field updates #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SIMD-0231: Disable account rent epoch field updates #231

wants to merge 1 commit into from

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented Jan 23, 2025

No description provided.

@jstarry jstarry changed the title SIMD-XXXX: Disable account rent epoch field updates SIMD-0231: Disable account rent epoch field updates Jan 23, 2025
@jstarry jstarry requested a review from brooksprumo January 23, 2025 05:50
@jstarry jstarry mentioned this pull request Jan 23, 2025
Open
brooksprumo
brooksprumo approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I like this; getting rid of all modifications to rent_epoch will (1) be more consistent, (2) allow us to rip out more rent collection code.

@HaoranYi HaoranYi self-requested a review January 24, 2025 17:35
@HaoranYi
Copy link
Contributor

HaoranYi commented Jan 24, 2025 •
edited
Loading

After this proposal has been applied and activated, new accounts will be
distinguishable from old accounts because they will have a different rent epoch
field. This will be observable both onchain and offchain until the rent epoch
field is fully deprecated in a future proposal.

I had a little concern about this. Does this mean "all" new accounts created after the feature activated will have rent_epoch = 0?
Old account will still have rent_epoch = max even if it written again?

@github-actions github-actions bot mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo approved these changes

@HaoranYi HaoranYi Awaiting requested review from HaoranYi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstarry @HaoranYi @brooksprumo