-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPL Token fundraiser program example #82
Conversation
@Woody4618 Could you have a look when you have the time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, thank you for writing this \o/
I added some questions. Would be nice if you could address. Them in general its great.
I also ran the tests. All green :)
tokens/token-fundraiser/anchor/programs/fundraiser/src/instructions/initialize.rs
Outdated
Show resolved
Hide resolved
tokens/token-fundraiser/anchor/programs/fundraiser/src/instructions/refund.rs
Outdated
Show resolved
Hide resolved
const tx = await program | ||
.methods | ||
.initialize(new anchor.BN(30000000), 0) | ||
.accountsPartial({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you are using accountsPartial here instead of accounts? With anchor 30 you can save a bunch of these accounts probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal, since it is an example, is just to show all the accounts needed being passed
Thank you for the changes. Could you please pull in master and run the biome checks. You can find them in the package.json. will probably do the trick. |
Should be ok now |
@ASCorreia What's the required anchor and solana version? |
@heyAyushh It was initially Anchor 0.30.0 and Solana 1.18.12, and yesterday I migrated it to Anchor 0.30.1 and Solana 1.18.8 after seeing the issues in the job work |
Added NFT operations program example |
SPL Token Program with anchor 0.30 and Solana Program 1.18