Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPL Token fundraiser program example #82

Merged
merged 31 commits into from
Jun 26, 2024
Merged

SPL Token fundraiser program example #82

merged 31 commits into from
Jun 26, 2024

Conversation

ASCorreia
Copy link
Contributor

SPL Token Program with anchor 0.30 and Solana Program 1.18

@ASCorreia
Copy link
Contributor Author

@Woody4618 Could you have a look when you have the time?

@Woody4618 Woody4618 assigned Woody4618 and unassigned Woody4618 Jun 18, 2024
@Woody4618 Woody4618 self-requested a review June 18, 2024 14:45
Copy link
Collaborator

@Woody4618 Woody4618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, thank you for writing this \o/

I added some questions. Would be nice if you could address. Them in general its great.

I also ran the tests. All green :)

tokens/token-fundraiser/anchor/tests/fundraiser.ts Outdated Show resolved Hide resolved
const tx = await program
.methods
.initialize(new anchor.BN(30000000), 0)
.accountsPartial({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you are using accountsPartial here instead of accounts? With anchor 30 you can save a bunch of these accounts probably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal, since it is an example, is just to show all the accounts needed being passed

tokens/token-fundraiser/anchor/tests/fundraiser.ts Outdated Show resolved Hide resolved
tokens/token-fundraiser/anchor/readme.MD Show resolved Hide resolved
tokens/token-fundraiser/anchor/readme.MD Outdated Show resolved Hide resolved
tokens/token-fundraiser/anchor/readme.MD Outdated Show resolved Hide resolved
tokens/token-fundraiser/anchor/readme.MD Outdated Show resolved Hide resolved
tokens/token-fundraiser/anchor/readme.MD Outdated Show resolved Hide resolved
@ASCorreia ASCorreia requested a review from Woody4618 June 18, 2024 17:45
@Woody4618
Copy link
Collaborator

Thank you for the changes. Could you please pull in master and run the biome checks. You can find them in the package.json.
running
pnpm lint:fix
and
pnpm format:fix

will probably do the trick.

@ASCorreia
Copy link
Contributor Author

Should be ok now

@heyAyushh
Copy link
Member

@ASCorreia What's the required anchor and solana version?
I guess for anchor it's 0.30.1?

@ASCorreia
Copy link
Contributor Author

@heyAyushh It was initially Anchor 0.30.0 and Solana 1.18.12, and yesterday I migrated it to Anchor 0.30.1 and Solana 1.18.8 after seeing the issues in the job work

@ASCorreia
Copy link
Contributor Author

Added NFT operations program example

@jacobcreech jacobcreech merged commit 82e5f16 into solana-developers:main Jun 26, 2024
4 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants