Added extension nft meta data pointer example #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brimigs
reviewed
Mar 2, 2024
...22/nft-meta-data-pointer/anchor/program/programs/extension_nft/src/instructions/chop_tree.rs
Outdated
Show resolved
Hide resolved
...22/nft-meta-data-pointer/anchor/program/programs/extension_nft/src/instructions/chop_tree.rs
Show resolved
Hide resolved
...022/nft-meta-data-pointer/anchor/program/programs/extension_nft/src/instructions/mint_nft.rs
Outdated
Show resolved
Hide resolved
...022/nft-meta-data-pointer/anchor/program/programs/extension_nft/src/instructions/mint_nft.rs
Show resolved
Hide resolved
|
|
||
| impl GameData { | ||
| pub fn on_tree_chopped(&mut self, amount_chopped: u64) -> Result<()> { | ||
| match self.total_wood_collected.checked_add(amount_chopped) { |
There was a problem hiding this comment.
missing error handling for checked.add() should have an .ok_or_else() to handle any overflow errors otherwise it could contribute to silent errors in the game
There was a problem hiding this comment.
Isnt the "match" doing exactly that check? If none its an overflow if some it worked. Or are there also other cases then it returns none?
| } | ||
|
|
||
| pub fn chop_tree(&mut self, amount: u64) -> Result<()> { | ||
| match self.wood.checked_add(amount) { |
There was a problem hiding this comment.
missing overflow handing with checked_add() and checked_sub(). Would suggest adding in ok_or_else()
Something like this:
let new_wood = self.wood.checked_add(amount).ok_or_else(|| { msg!("Overflow error: Too much wood collected."); ProgramError::InvalidArgument })?;
brimigs
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example on how to create NFTs with the token meta data pointer extension and additional meta data with nextjs app, unity client and anchor program.