Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority fees as optional flag #43

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

arrayappy
Copy link
Contributor

Problem #38

Summary of Changes

  • added --priority-fees command option to commands.ts
  • updated deploy command to have --priority-fees

Fixes #38

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 73da087

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mucho Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arrayappy arrayappy changed the title Priority fees Priority fees as optional flag Jan 29, 2025
Copy link
Member

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this :) Let's rename it to be singular "priority fee"

Can you also create/commit a changeset via pnpm changeset in order to create a changelog entry?

src/const/commands.ts Outdated Show resolved Hide resolved
src/lib/shell/deploy.ts Outdated Show resolved Hide resolved
src/lib/shell/deploy.ts Outdated Show resolved Hide resolved
src/lib/shell/deploy.ts Outdated Show resolved Hide resolved
@arrayappy
Copy link
Contributor Author

arrayappy commented Jan 30, 2025

Thanks you reviewing, I've resolved all your comments and added changeset.

@nickfrosty nickfrosty merged commit df39fac into solana-developers:master Jan 30, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add priority fees option as a plug and play flag
2 participants