feat: add sync-schema script to sync generator schema.json to d.ts #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfrosty
reviewed
Nov 9, 2023
| name: string | ||
| skipFormat?: boolean | ||
| template?: ApplicationAnchorTemplate | ||
| name: string; |
There was a problem hiding this comment.
The name arg for most of the generators is not adding the description into the generated schema.d.ts files.
It looks like the name property for each of the 3 current presets do not have a description set. Is there a reason for that? (they do have a prompt text, just not description)
There was a problem hiding this comment.
Just added the description to the schema.json files and now they get added
nickfrosty
approved these changes
Nov 9, 2023
beeman
force-pushed
the
beeman/schema-generations
branch
from
cbd8c84 to
78e1e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the script
tools/scripts/sync-schemas.tsthat generates the*-schema.d.tsfiles based on the content in the-schema.jsonfiles for our generators using the json-schema-to-typescript package.It also adds a check to the pre-commit hook to prevent committing an outdated schema. You can run
yarn sync-schemasto sync them.To make this work I moved around the
NormalizedApplicationFooSchemainterfaces and other custom types and put them in the same file as the normalize function.