Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code action for creating module files. #5

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Code action for creating module files. #5

merged 1 commit into from
Dec 3, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Dec 2, 2024

@Draggu Draggu requested a review from a team as a code owner December 2, 2024 10:57
@Draggu Draggu requested review from piotmag769 and integraledelebesgue and removed request for a team December 2, 2024 10:57
piotmag769
piotmag769 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for merge on cairo's side

tests/test_data/code_actions/create_module_file.txt Outdated Show resolved Hide resolved
src/ide/code_actions/create_module_file.rs Show resolved Hide resolved
src/ide/code_actions/create_module_file.rs Show resolved Hide resolved
@Draggu Draggu force-pushed the spr/main/1ad7dd71 branch from c158bdd to c5c5caa Compare December 2, 2024 16:58
@Draggu Draggu requested a review from mkaput December 3, 2024 10:34
@Draggu Draggu added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 3c26972 Dec 3, 2024
22 checks passed
@Draggu Draggu deleted the spr/main/1ad7dd71 branch December 3, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

@mkaput mkaput mkaput approved these changes

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue integraledelebesgue is a code owner automatically assigned from software-mansion/cairo-ls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Draggu @mkaput @piotmag769