Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code action to implement missing trait members #4

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add code action to implement missing trait members #4

merged 1 commit into from
Dec 11, 2024

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Dec 2, 2024 •
edited
Loading

Closes starkware-libs/cairo#5944

Changes

  • If impl block is missing some members of an implemented trait, a quick fix filling those members appears
  • Known generic arguments are inserted in impls, unknown substituted with placeholders
  • Inserted code is not formatted

@integraledelebesgue integraledelebesgue requested a review from a team as a code owner December 2, 2024 10:38
@integraledelebesgue integraledelebesgue requested review from mkaput, Arcticae and a team and removed request for a team December 2, 2024 10:38
@integraledelebesgue integraledelebesgue force-pushed the feature/fill-trait-members branch from 7a78ff3 to c543c23 Compare December 2, 2024 12:18
@mkaput mkaput requested review from piotmag769 and removed request for mkaput December 2, 2024 13:35
@integraledelebesgue integraledelebesgue force-pushed the feature/fill-trait-members branch 7 times, most recently from c050c1c to 37cc45b Compare December 4, 2024 13:09
piotmag769
piotmag769 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job, best PR I have seen lately when it comes to edge cases handling and precision

src/ide/code_actions/fill_trait_members.rs Show resolved Hide resolved
@piotmag769 piotmag769 mentioned this pull request Dec 11, 2024
Closed
Arcticae
Arcticae reviewed Dec 11, 2024
View reviewed changes
src/ide/code_actions/fill_trait_members.rs Outdated Show resolved Hide resolved
src/ide/code_actions/fill_trait_members.rs Show resolved Hide resolved
src/ide/code_actions/fill_trait_members.rs Show resolved Hide resolved
src/ide/code_actions/mod.rs Show resolved Hide resolved
@integraledelebesgue integraledelebesgue force-pushed the feature/fill-trait-members branch 2 times, most recently from 18b9792 to 11e287a Compare December 11, 2024 10:50
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit dc6ffe5 Dec 11, 2024
11 checks passed
@integraledelebesgue integraledelebesgue deleted the feature/fill-trait-members branch December 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

@Arcticae Arcticae Arcticae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide intention to fill trait members
3 participants
@integraledelebesgue @Arcticae @piotmag769