Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ShowMessage where possible #20

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

piotmag769
Copy link
Contributor

@piotmag769 piotmag769 commented Dec 3, 2024

Closes: starkware-libs/cairo#6814

The handling on the vscode extension side has to stay to support previous LS versions :/

@piotmag769 piotmag769 requested a review from a team as a code owner December 3, 2024 15:54
@piotmag769 piotmag769 requested review from mkaput, integraledelebesgue and Draggu and removed request for a team December 3, 2024 15:54
src/project/mod.rs Outdated Show resolved Hide resolved
@piotmag769 piotmag769 force-pushed the migrate-to-show-message branch from fa3c8cd to 4176faa Compare December 4, 2024 08:38
src/lang/proc_macros/controller.rs Outdated Show resolved Hide resolved
@piotmag769 piotmag769 force-pushed the migrate-to-show-message branch from 4176faa to ac08d33 Compare December 4, 2024 11:28
@piotmag769 piotmag769 requested a review from Draggu December 4, 2024 11:28
@piotmag769 piotmag769 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit fece532 Dec 4, 2024
3 checks passed
@piotmag769 piotmag769 deleted the migrate-to-show-message branch December 4, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate most custom notifications to showMessage
3 participants