Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect declarations in textDocument/references implementation #123

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Dec 20, 2024

src/lang/inspect/refs.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really gj

@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from 4b1f657 to b4d27d4 Compare January 7, 2025 08:51
@mkaput mkaput force-pushed the spr/main/c0e7d4d8 branch from 8a54322 to 34f14eb Compare January 7, 2025 08:51
@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from b4d27d4 to a997969 Compare January 7, 2025 09:12
@mkaput mkaput force-pushed the spr/main/c0e7d4d8 branch from 34f14eb to cba99ea Compare January 7, 2025 09:12
@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from a997969 to d4ad399 Compare January 7, 2025 09:14
@mkaput mkaput force-pushed the spr/main/c0e7d4d8 branch from cba99ea to 042fa7e Compare January 7, 2025 09:14
@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from d4ad399 to 64fe6e1 Compare January 7, 2025 09:21
@mkaput mkaput force-pushed the spr/main/c0e7d4d8 branch from 042fa7e to 2ba3913 Compare January 7, 2025 09:21
@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from 64fe6e1 to af43182 Compare January 8, 2025 09:04
@mkaput mkaput force-pushed the spr/main/c0e7d4d8 branch from 2ba3913 to 6e30cae Compare January 8, 2025 09:04
@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from af43182 to 70067e5 Compare January 9, 2025 06:22
@mkaput mkaput force-pushed the spr/main/c0e7d4d8 branch from 6e30cae to 09105d9 Compare January 9, 2025 06:22
@mkaput mkaput requested review from Copilot and removed request for Draggu January 9, 2025 06:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • tests/test_data/references/fns.txt: Language not supported
Comments suppressed due to low confidence (1)

src/ide/navigation/references.rs:9

  • Ensure that the behavior of the references function, especially its interaction with find_all_references, is covered by tests.
pub fn references(params: ReferenceParams, db: &AnalysisDatabase) -> Option<Vec<Location>> {

src/lang/inspect/refs.rs Outdated Show resolved Hide resolved
Base automatically changed from spr/main/c0e7d4d8 to main January 9, 2025 13:14
@mkaput mkaput force-pushed the spr/main/67cec2e0 branch from 70067e5 to 428bb02 Compare January 9, 2025 15:38
@mkaput mkaput added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 28f7705 Jan 10, 2025
11 checks passed
@mkaput mkaput deleted the spr/main/67cec2e0 branch January 10, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants