-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect declarations in textDocument/references
implementation
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
requested review from
Arcticae and
Draggu
and removed request for
a team
December 20, 2024 12:40
This was referenced Dec 20, 2024
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
December 20, 2024 15:23
3403069
to
8a54322
Compare
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
December 20, 2024 15:23
bbc1c95
to
4b1f657
Compare
Arcticae
approved these changes
Dec 20, 2024
piotmag769
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really gj
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 7, 2025 08:51
4b1f657
to
b4d27d4
Compare
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
January 7, 2025 08:51
8a54322
to
34f14eb
Compare
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 7, 2025 09:12
b4d27d4
to
a997969
Compare
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
January 7, 2025 09:12
34f14eb
to
cba99ea
Compare
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 7, 2025 09:14
a997969
to
d4ad399
Compare
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
January 7, 2025 09:14
cba99ea
to
042fa7e
Compare
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 7, 2025 09:21
d4ad399
to
64fe6e1
Compare
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
January 7, 2025 09:21
042fa7e
to
2ba3913
Compare
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 8, 2025 09:04
64fe6e1
to
af43182
Compare
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
January 8, 2025 09:04
2ba3913
to
6e30cae
Compare
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 9, 2025 06:22
af43182
to
70067e5
Compare
mkaput
force-pushed
the
spr/main/c0e7d4d8
branch
from
January 9, 2025 06:22
6e30cae
to
09105d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- tests/test_data/references/fns.txt: Language not supported
Comments suppressed due to low confidence (1)
src/ide/navigation/references.rs:9
- Ensure that the behavior of the
references
function, especially its interaction withfind_all_references
, is covered by tests.
pub fn references(params: ReferenceParams, db: &AnalysisDatabase) -> Option<Vec<Location>> {
commit-id:67cec2e0
mkaput
force-pushed
the
spr/main/67cec2e0
branch
from
January 9, 2025 15:38
70067e5
to
428bb02
Compare
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
textDocument/references
#155SymbolDef::name
method #154ModuleDef
#153SymbolDef::ExprInlineMacro
asSmolStr
instead ofString
#152textDocument/references
implementation #123 ⬅