Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes a number of validation issues #391

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

gablaxian
Copy link
Contributor

Due to the automatic conversion process, it seemed that there were a fair number of duplicate example objects that were making the spec both invalid and larger than necessary.

Two issues remain:

  • Paths "/org/{orgId}/integrations/{integrationId}" and "/org/{orgId}/integrations/{type}" must not be equivalent.
  • "value" property must have required property "broker"

The first is a limitation of OpenAPI itself. The other is a known issue where the conversion process did not account for multiple responses on the same endpoint, when different parameters are passed, which is correctly documented in the Apiary site. We will address this in another fix.

Due to the automatic conversion process, it seemed that there were a fair number of duplicate example objects that were making the spec both invalid and larger than necessary.

Two issues remain:
 - `Paths "/org/{orgId}/integrations/{integrationId}" and "/org/{orgId}/integrations/{type}" must not be equivalent.`
 - `"value" property must have required property "broker"`

 The first is a limitation of OpenAPI itself. The other is a known issue where the conversion process did not account for multiple responses on the same endpoint, when different parameters are passed, which is correctly documented in the Apiary site. We will address this in another fix.
@gablaxian gablaxian requested review from a team as code owners November 8, 2024 13:14
@gablaxian gablaxian merged commit 90abd48 into main Nov 11, 2024
5 checks passed
@gablaxian gablaxian deleted the docs/v1-spec-validation-fixes branch November 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant