Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JB config - Customize first batch of values to be SnowEx specific #1

Merged
merged 2 commits into from
May 31, 2024

Conversation

jomey
Copy link
Member

@jomey jomey commented May 23, 2024

No description provided.

@jomey jomey requested review from scottyhq, aaarendt and spestana May 23, 2024 23:20
Copy link
Member

@aaarendt aaarendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught one correction on the dates, otherwise this looks good!

There are general edits to the template that apply to all events, namely we need to remove the description of the projects given PR 59 moved this content to the guidebook. I'm assuming we'll deal with that in a separate PR?

@@ -13,5 +13,5 @@
:class: seealso
* JupyterHub: {{ jupyterhub_url }}
* GitHub organization: {{ github_org_url}}
* Projects Spreadsheet: {{ project_spreadsheet_url }}
* [List of projects](projects/list_of_projects)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change - we should discuss if there will be some other resource or link for participants to see a list of proposed projects, since here we will only list those that have turned into active projects. Probably we'll just do that on Slack.

book/_config.yml Outdated Show resolved Hide resolved
@jomey
Copy link
Member Author

jomey commented May 31, 2024

There are general edits to the template that apply to all events, namely we need to remove the description of the projects given PR 59 moved this content to the guidebook. I'm assuming we'll deal with that in a separate PR?

Are you thinking of these pages:
https://snowex-2024.hackweek.io/projects/index.html

I would suggest to remove those in a separate PR once the above mentioned one is merged.

Dates were still showing the last event.
Great catch by @aaarendt
@jomey jomey merged commit ce5c9bf into main May 31, 2024
3 checks passed
@jomey jomey deleted the update_config branch May 31, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants