-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds try/catch around notification failing with an inactive webhook for better user experience #16050
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a warning or info? The red error makes it look like the checkout might not have worked, even though it did. I'd say if you're going to fire two error bags, make one "success" and then the next one an info - or combine them and make it a warning.
(I know what the messages say, but I also know what people will read.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a try and it worked. Code is good but I do recommend @snipe's suggestion of changing it to a warning.
forgot to make it a translation--1 sec |
good 👍 |
When checking in and checking out, if the webhook notification fires and there is an error, it now redirects back with an error message