Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Form::open to blade component #15993

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Dec 20, 2024

This PR introduces the <x-form> component and uses it place of Form::open.


Pages affected

Modals Affected

Copy link

what-the-diff bot commented Dec 20, 2024

PR Summary

  • Reformulated Form Handling Approach: Transitioned from traditional methods to a more streamlined <x-form> component. This change helps enhance reusability while simplifying the form's underlying framework in various 'Blade' template files.
  • Implementation of a Central <x-form> Component: A new form creation logic centralization file was added, making attribute management (like method and files) more straightforward.
  • Form Views Update: Upgraded form handling across several areas, including account management, hardware handling, custom fields, models, and reports, to capitalize on the new <x-form> structure.
  • Enhanced Attribute Binding: Route parameters can now be dynamically bound in forms through templates (e.g., :route), allowing for increased adaptability.
  • Uniform Form Handling: Form handling is now consistent across all views, improving code readability and ease of maintenance.
  • Updated Routes in Various Files: Routes in asset_tags, backups, branding, google, labels, localization, purge-form, and saml files have been updated for efficient use of the route function with named routes.
  • Removal of Redundant CSRF Tokens: Eliminated redundant CSRF tokens, assuming the <x-form> component handles CSRF automatically.
  • Improved Form Closing Mechanism: Replaced some traditional closing tags with </form>, corresponding to areas where the traditional Form facade was updated.
  • Elimination of Extra Closing Form Tags: Removed unnecessary closing form tags in statuslabels/view and users/index files, improving the overall code neatness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant