-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve javascript #15175
Open
uberbrady
wants to merge
12
commits into
snipe:develop
Choose a base branch
from
uberbrady:improve_javascript
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve javascript #15175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@uberbrady Are we still looking to take this? We have conflicts, but only in the build stuff, which shouldn't matter, I wouldn't think |
Yes, I'm definitely still interested in this. I'll see if I can get the conflicts resolved, at least. |
Yay! After pushing up the build artifacts, the tests seem to pass OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main goal here was to get our build-cycle to use
require()
statements rather than concatenating files together. This puts us on a path to use Laravel Vite instead of Webpack to generate our assets. This also makes the webpack config file easier to read, and has us making library-level changes more at the snipeit.js level. This process was made much easier by the fact that the bulk of everything we do is powered by jQuery - so once you have a working jQuery object, everything just attaches itself to that.I was able to get rid of the 'stub' bootstrap.js file (that file means "Bootstrapping the JavaScript" - no relation to bootstrap, the CSS framework). I just included the main contents at the top of snipeit.js.
I was able to remove an entire step from the build-cycle, which is a bonus. I also added in SourceMaps, which should make troubleshooting our Javascript much easier when the problem is somewhere within our all.js file.
I could keep going but I didn't want to paint myself into a corner, and this is already a little easier to understand than what we had going before.
I haven't clicked around everything in the app, but I did find places where the new generated all.js file wasn't working, but was able to fix those. I imagine I probably missed some more things. I tried to leave comments in the snipeit.js file to explain what files are being included, and why.
There are some files that get generated that aren't included in
.git
- I decided not to add them here, since we tend to build JS/CSS assets before releases, they'll show up again.But this is at least a start.