Add tests for color helper

snipe · Nov 8, 2023 · 49136a4 · 49136a4
1 parent 4382adc
commit 49136a4
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 25 deletions.
diff --git a/app/Helpers/Helper.php b/app/Helpers/Helper.php
@@ -73,10 +73,14 @@ public static function formatCurrencyOutput($cost)
      *
      * @author [A. Gianotto] [<[email protected]>]
      * @since [v3.3]
-     * @return array
+     * @return string
      */
-    public static function defaultChartColors($index = 0)
+    public static function defaultChartColors(int $index = 0)
     {
+        if ($index < 0) {
+            $index = 0;
+        }
+
         $colors = [
             '#008941',
             '#FF4A46',
@@ -359,8 +363,8 @@ public static function defaultChartColors($index = 0)
             if($index < 0) {
                 $index = 0;
             }
-            elseif($index > 265) {
-                $index = 265;
+            elseif($index >($total_colors - 1)) {
+                $index = $total_colors - 1;
             }
         }
 

diff --git a/tests/Feature/DefaultColorKeyTest.php b/tests/Feature/DefaultColorKeyTest.php
diff --git a/tests/Unit/Helpers/HelperTest.php b/tests/Unit/Helpers/HelperTest.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace Tests\Unit\Helpers;
+
+use App\Helpers\Helper;
+use Tests\TestCase;
+
+class HelperTest extends TestCase
+{
+    public function testDefaultChartColorsMethodHandlesHighValues()
+    {
+        $this->assertIsString(Helper::defaultChartColors(1000));
+    }
+
+    public function testDefaultChartColorsMethodHandlesNegativeNumbers()
+    {
+        $this->assertIsString(Helper::defaultChartColors(-1));
+    }
+}