-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve update script #4
base: master
Are you sure you want to change the base?
Conversation
If this script runs scheduled it should not re-tag a commit nor exit with non-zero when everything is dealt with. |
Im aware of the issue. I think a cleaner solution is to maybe split this script into two parts and then use two Workflow steps in GitHub action. That would be useful in the actions UI because right now you cant really see which workflow triggered an update and which one had no diff. |
|
||
git add -A | ||
git commit -a -m "Automatic release for WordPress: ${php_stubs_latest_version}" | ||
git tag "${php_stubs_latest_version}" HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git tag "${php_stubs_latest_version}" HEAD | |
git tag "v${php_stubs_latest_version}" HEAD |
Here goes v
as "version".
AFAIK GitHub Actions has no way to show this. A scheduled run can succeed or fail. |
I've found "job summaries": https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary |
@calvinalkan Friendly ping 🏓 from the future. |
@calvinalkan Please fix my commit thingy!