Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve update script #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link

@calvinalkan Please fix my commit thingy!

@szepeviktor
Copy link
Author

szepeviktor commented Jun 6, 2022

If this script runs scheduled it should not re-tag a commit nor exit with non-zero when everything is dealt with.

@calvinalkan
Copy link
Member

Im aware of the issue. I think a cleaner solution is to maybe split this script into two parts and then use two Workflow steps in GitHub action. That would be useful in the actions UI because right now you cant really see which workflow triggered an update and which one had no diff.


git add -A
git commit -a -m "Automatic release for WordPress: ${php_stubs_latest_version}"
git tag "${php_stubs_latest_version}" HEAD
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git tag "${php_stubs_latest_version}" HEAD
git tag "v${php_stubs_latest_version}" HEAD

Here goes v as "version".

@szepeviktor
Copy link
Author

That would be useful in the actions UI because right now you cant really see which workflow triggered an update and which one had no diff.

AFAIK GitHub Actions has no way to show this. A scheduled run can succeed or fail.
I do not recommend failed jobs!

@szepeviktor
Copy link
Author

@szepeviktor
Copy link
Author

@calvinalkan Friendly ping 🏓 from the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants