-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rss.from_as1: remove possible addition of invalid author element #847
Conversation
a841d77
to
61cac45
Compare
It seems I've gotten a bit lost in fixing up the tests -- I'll get back to this later, sorry :) |
This looks great! Thank you for the contribution! I think you're almost there, don't let the tests get you down. |
Co-authored-by: Ryan Barrett <[email protected]>
Tests are passing! Awesome! One small comment left, and please also add an entry to the changelog in the readme: Lines 339 to 340 in 55b5610
...then I think we're ready to merge! |
3975a03
to
79a8f54
Compare
Love it. Merging, thank you again! cc @capjamesg, let me know if you install granary from GitHub or if you need a new release on PyPi for this. |
I have just installed Granary from source for the hosted version of the Papers with Code RSS feed. Thank you everyone for the fix! |
Oh wait, this pertains to the HF Papers project. I see. @snarfed The project depends on the hosted version of granary at
The hosted version would thus need to be updated to use the latest GitHub version. |
Deployed to granary.io! |
I appreciate this project, thanks for your work on it!
Here's a change that I think will fix a few broken cases such as this one that directly publish RSS converted from JSON feeds via granary.io.
In brief, we adhere closer to the RSS spec by removing the use of the default author email value
'-'
when constructing an RSS item.(relevant upstream project code: https://github.com/lkiesow/python-feedgen/blob/v1.0.0/feedgen/entry.py#L366-L372)
illustrative example
https://granary.io/url?input=jsonfeed&output=rss&url=https://jamesg.blog/hf-papers.json
The above link produces an RSS file that at the time of writing is technically invalid when checked. This invalidity appears to break some RSS readers.
url.rss excerpt