Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add members space page #971

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat: add members space page #971

wants to merge 24 commits into from

Conversation

bartosz-io
Copy link

Summary

Add a new space page and item in the space menu called "Members".

Closes: #960

How to test

  1. Open a space with members
  2. Verify Members navigation item is visible
  3. Open Members
  4. If there are no members (admin, moderator, author) the navigation item is not rendered

@bonustrack bonustrack requested a review from Sekhmet November 26, 2024 17:54
@bonustrack
Copy link
Member

@Sekhmet can you review this PR?

Sekhmet
Sekhmet reviewed Nov 27, 2024
View reviewed changes
apps/ui/src/components/App/Nav.vue Outdated Show resolved Hide resolved
apps/ui/src/components/App/Nav.vue Outdated Show resolved Hide resolved
apps/ui/src/components/App/Nav.vue Outdated Show resolved Hide resolved
apps/ui/src/networks/offchain/api/queries.ts Outdated Show resolved Hide resolved
Sekhmet
Sekhmet reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where -> statementsWhere rename went wrong so query doesn't work right now.

Also recently we added class to our routes, but because SpaceMembers returns fragment that class doesn't have anywhere to go so we get a warning and padding is missing on this page:

sx-monorepo/apps/ui/src/components/Layout/App.vue

Line 208 in 7253f12

<router-view class="pb-6" />

@bartosz-io
Copy link
Author

@Sekhmet Fixed.

Could you approve?

@bartosz-io
Copy link
Author

@Sekhmet I hope we can merge the PR :)

Sekhmet
Sekhmet approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thank you!

@Sekhmet Sekhmet requested a review from bonustrack January 6, 2025 13:40
@bonustrack bonustrack added the invalid This doesn't seem right label Jan 6, 2025
@bonustrack
Copy link
Member

This PR was done as a developer challenge, please dont merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add members space page
3 participants
@bartosz-io @bonustrack @Sekhmet