Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sticky nav jumping on narrow screen #685

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/ui/src/components/Ui/Label.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ defineProps<{
<h4
class="eyebrow border-b py-2 px-4 text-skin-text"
:class="{
'sticky z-10 top-[71px] lg:top-[72px] bg-skin-bg': sticky
'sticky z-10 top-[72px] bg-skin-bg': sticky
}"
v-text="label"
/>
Expand Down
2 changes: 1 addition & 1 deletion apps/ui/src/views/Proposal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ watchEffect(() => {
<template v-else>
<div class="flex-1 md:mr-[340px]">
<div
class="flex px-4 bg-skin-bg border-b sticky top-[71px] lg:top-[72px] z-40 space-x-3"
class="flex px-4 bg-skin-bg border-b sticky top-[72px] z-40 space-x-3"
>
<router-link
:to="{
Expand Down
2 changes: 1 addition & 1 deletion apps/ui/src/views/Space/Delegates.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ watchEffect(() => setTitle(`Delegates - ${props.space.name}`));
<template v-else>
<UiScrollerHorizontal
v-if="space.delegations.length > 1"
class="z-40 sticky top-[71px] lg:top-[72px]"
class="z-40 sticky top-[72px]"
gradient="md"
>
<div class="flex px-4 space-x-3 bg-skin-bg border-b min-w-max">
Expand Down
2 changes: 1 addition & 1 deletion apps/ui/src/views/Space/Treasury.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ watchEffect(() => setTitle(`Treasury - ${props.space.name}`));
<UiScrollerHorizontal
v-if="filteredTreasuries.length !== 1"
gradient="md"
class="z-40 sticky top-[71px] lg:top-[72px]"
class="z-40 sticky top-[72px]"
>
<div class="flex px-4 space-x-3 bg-skin-bg border-b min-w-max">
<button
Expand Down
5 changes: 1 addition & 4 deletions apps/ui/src/views/SpaceUser.vue
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,7 @@ watch(
</div>
</div>
</div>
<UiScrollerHorizontal
class="z-40 sticky top-[71px] lg:top-[72px]"
gradient="md"
>
<UiScrollerHorizontal class="z-40 sticky top-[72px]" gradient="md">
<div class="flex px-4 space-x-3 bg-skin-bg border-b min-w-max">
<router-link
v-for="(item, i) in navigation"
Expand Down
Loading