Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix circular dependencies #676

Closed
wants to merge 3 commits into from
Closed

fix circular dependencies #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049a64f
moved voting from utils to top level
mktcode Aug 3, 2022
2969e5e
moved validations from utils to top level
mktcode Aug 3, 2022
5806a97
bump version number to 1.0.0
mktcode Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@snapshot-labs/snapshot.js",
"version": "0.4.13",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep v1 for a big refactoring?

"repository": "snapshot-labs/snapshot.js",
"license": "MIT",
"main": "dist/snapshot.cjs.js",
Expand Down
6 changes: 5 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ import Client712 from './sign';
import Client from './client';
import schemas from './schemas';
import utils from './utils';
import validations from './validations';
import voting from './voting';

export default {
Client,
Client712,
schemas,
utils
utils,
validations,
voting
};
4 changes: 0 additions & 4 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ import addFormats from 'ajv-formats';
import Multicaller from './utils/multicaller';
import { getSnapshots } from './utils/blockfinder';
import getProvider from './utils/provider';
import validations from './validations';
import { signMessage, getBlockNumber } from './utils/web3';
import { getHash, verify } from './sign/utils';
import gateways from './gateways.json';
import networks from './networks.json';
import voting from './voting';

interface Options {
url?: string;
Expand Down Expand Up @@ -350,13 +348,11 @@ export default {
clone,
sleep,
getNumberWithOrdinal,
voting,
getProvider,
signMessage,
getBlockNumber,
Multicaller,
getSnapshots,
validations,
getHash,
verify,
SNAPSHOT_SUBGRAPH_URL
Expand Down