Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow https in domain #1074

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: Allow https in domain #1074

merged 2 commits into from
Oct 16, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 15, 2024 •
edited
Loading

Related to https://github.com/snapshot-labs/workflow/issues/253

Allow https in domain

How to test:

  • Run yarn test
  • Edit test/examples/space.json with different domain values

@ChaituVR ChaituVR requested a review from wa0x6e October 15, 2024 06:52
@ChaituVR ChaituVR mentioned this pull request Oct 15, 2024
Merged
@ChaituVR ChaituVR merged commit b395299 into master Oct 16, 2024
4 checks passed
@ChaituVR ChaituVR deleted the allow-https-in-domain branch October 16, 2024 04:58
@ChaituVR ChaituVR mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@wa0x6e wa0x6e Awaiting requested review from wa0x6e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @bonustrack