feat: allow getDelegatesBySpace to fetch delegates for all spaces #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change space can be passed as null and this will result in all delegates to be returned instead of per-space results only. This will be used on new delegate-registry-api.
ChaituVR
reviewed
Aug 23, 2024
| @@ -26,7 +26,7 @@ export default async function getDelegatesBySpace( | |||
|
|
|||
| let pivot = 0; | |||
| const result = new Map<string, Delegation>(); | |||
| const spaceIn = buildSpaceIn(space); | |||
| const spaceIn = space ? buildSpaceIn(space) : null; | |||
There was a problem hiding this comment.
It takes too much time to get all delegations 😅 (100.418 seconds for mainnet delegations) but yea it works
There was a problem hiding this comment.
Yeah, this will be reused on the server to only do it once every 24 hours for all spaces on given network so it shouldn't be terrible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change space can be passed as null and this will result in all delegates to be returned instead of per-space results only.
This will be used on new delegate-registry-api.