Migrated notifications to Firebase #3198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
|
Can you fix the conflicts here? |
samuveth
reviewed
Oct 4, 2022
| VITE_ENV=develop | ||
| VITE_VAPID_KEY= |
There was a problem hiding this comment.
These should both have a default value that will work out of the box
samuveth
reviewed
Oct 4, 2022
| ); | ||
|
|
||
| const firebaseConfig = { | ||
| // TODO: config |
There was a problem hiding this comment.
What needs to be done here?
samuveth
reviewed
Oct 4, 2022
| @@ -23,5 +23,6 @@ | |||
| "start_url": ".", | |||
| "display": "standalone", | |||
| "theme_color": "#000000", | |||
| "background_color": "#ffffff" | |||
| "background_color": "#ffffff", | |||
| "gcm_sender_id": "XXXXXXXXXXXX" | |||
There was a problem hiding this comment.
What does XXXXXXXXXXXX represent?
|
@eswarasai I've converted this PR to a draft as I see some things missing and the preview deployment doesn't work. |
|
@eswarasai can you resolve conflicts |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keep this |
samuveth
removed
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: snapshot-labs/snapshot-webhook#23
Changes in this PR:
Notificationtray on top right cornerHow to test and review this PR?
Notificationtray on top right cornerTODO:
src/helpers/firebase.ts(Ref: How to build standard javascript file (like firebase-messaging-sw.js) during vite dev for other service intergration. vitejs/vite#9023)