Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow shutter in proposal privacy if space is using shutter privacy #475

Merged
merged 22 commits into from
Jan 7, 2025
Merged

fix: Allow shutter in proposal privacy if space is using shutter privacy #475

merged 22 commits into from
Jan 7, 2025

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Dec 5, 2024 •
edited
Loading

Discussion snapshot-labs/sx-monorepo#954 (comment)

Summary

  • Modifies privacy check to Allow shutter in proposal privacy if space is using shutter privacy

How to test

@ChaituVR ChaituVR marked this pull request as draft December 5, 2024 15:18
@ChaituVR ChaituVR changed the title fix: update privacy check logic in proposal fix: Allow shutter in propsoal privacy if space is using shutter privacy Dec 5, 2024
@ChaituVR ChaituVR changed the title fix: Allow shutter in propsoal privacy if space is using shutter privacy fix: Allow shutter in proposal privacy if space is using shutter privacy Dec 5, 2024
@ChaituVR ChaituVR marked this pull request as ready for review December 5, 2024 15:46
@ChaituVR ChaituVR requested review from wa0x6e and Copilot December 5, 2024 15:48
Copilot
Copilot AI reviewed Dec 5, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
@ChaituVR ChaituVR mentioned this pull request Dec 5, 2024
Merged
@ChaituVR ChaituVR requested a review from bonustrack December 6, 2024 10:10
wa0x6e
wa0x6e requested changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some tests, and seems like 2 scenarios are failing

@ChaituVR
Copy link
Member Author

ChaituVR commented Jan 4, 2025

Fixed tests

@ChaituVR ChaituVR requested a review from wa0x6e January 6, 2025 14:47
wa0x6e
wa0x6e reviewed Jan 6, 2025
View reviewed changes
test/schema.sql Outdated Show resolved Hide resolved
test/unit/writer/proposal.test.ts Outdated Show resolved Hide resolved
@ChaituVR
Copy link
Member Author

ChaituVR commented Jan 7, 2025

Tests failing are not related to this PR, we can proceed without it

@ChaituVR ChaituVR requested a review from wa0x6e January 7, 2025 05:45
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/writer/update-proposal.ts 0.00% 6 Missing ⚠️
src/ingestor.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

wa0x6e
wa0x6e approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 1fc30c1 into master Jan 7, 2025
2 checks passed
@ChaituVR ChaituVR deleted the fix-privacy-check branch January 7, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@wa0x6e wa0x6e wa0x6e approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e