-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop formatting app property #463
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
6f66aaa
to
539eab9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
PR reverted to original 24 chars limit for Will update the limit again when database will be updated |
Need to revert on snapshot.js as well? |
Correct, see snapshot-labs/snapshot.js#1098 |
Toward https://github.com/snapshot-labs/workflow/issues/235
Discussion https://discord.com/channels/955773041898573854/1296435871431786587
This PR will accept
longer andunformattedapp
property for proposal and vote actions.Changes
app
chars limit bumped from 24 to 128 chars (to accept potential address)Formatting should be done on the UI side, to avoid formatting out-of-control of the sender, and to accepts checksummed addresses
Run the following SQL query to bump the column length: