Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop formatting app property #463

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 17, 2024

Toward https://github.com/snapshot-labs/workflow/issues/235
Discussion https://discord.com/channels/955773041898573854/1296435871431786587

This PR will accept longer and unformatted app property for proposal and vote actions.

Changes

  • app chars limit bumped from 24 to 128 chars (to accept potential address)
  • remove kebabcase formatting

Formatting should be done on the UI side, to avoid formatting out-of-control of the sender, and to accepts checksummed addresses

Run the following SQL query to bump the column length:

ALTER TABLE
  votes
MODIFY
  app varchar(128) NOT NULL;
ALTER TABLE
  proposals
MODIFY
  app varchar(128) NOT NULL;

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/writer/vote.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@wa0x6e wa0x6e marked this pull request as ready for review October 17, 2024 12:36
@wa0x6e wa0x6e requested a review from ChaituVR October 17, 2024 12:37
@wa0x6e wa0x6e force-pushed the fix-remove-app-kebabcase-formatting branch from 6f66aaa to 539eab9 Compare October 17, 2024 12:39
src/helpers/utils.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR October 17, 2024 16:30
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Oct 17, 2024

PR reverted to original 24 chars limit for app.

Will update the limit again when database will be updated

@wa0x6e wa0x6e changed the title feat: accept longer app property fix: stop formatting app property Dec 7, 2024
@wa0x6e wa0x6e merged commit 0c82c4e into master Dec 7, 2024
2 checks passed
@wa0x6e wa0x6e deleted the fix-remove-app-kebabcase-formatting branch December 7, 2024 02:42
@ChaituVR
Copy link
Member

ChaituVR commented Dec 7, 2024

Need to revert on snapshot.js as well?

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Dec 8, 2024

Need to revert on snapshot.js as well?

Correct, see snapshot-labs/snapshot.js#1098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants