Skip to content

Commit

Permalink
fix: enable more core24 snaps to build (#43)
Browse files Browse the repository at this point in the history
* ci: remove other platforms for core24
* ci: disable fallback for core24
* ci: restrict arches for core24
* ci: fix `build-log` path
  • Loading branch information
soumyaDghosh authored Jul 12, 2024
1 parent 6f41854 commit ad6972e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion release-to-candidate/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ runs:
if [[ "$(yq -r '.base' "$yaml_path")" == "core24" ]]; then
# `core24` uses platforms syntax rather than `architectures`:
# https://snapcraft.io/docs/architectures
SNAPCRAFT_REMOTE_BUILD_STRATEGY=disable-fallback
yq -i '.platforms |= {env(arch): {"build-on": env(arch)}}' "$yaml_path"
snapcraft_args+=("--platform $arch")
elif [[ "${{ steps.setup.outputs.new-remote-build }}" == "false" || "$SNAPCRAFT_REMOTE_BUILD_STRATEGY" == "force-fallback" ]]; then
# Restrict arch definition to one only in snapcraft.yaml due to:
Expand All @@ -132,7 +134,7 @@ runs:
snapcraft remote-build ${snapcraft_args[@]} || true
# shellcheck disable=SC2086
cat ${name}_${arch}*.txt || echo "Could not find build log"
cat snapcraft-${name}*${arch}*.txt || echo "Could not find build log"
if [[ ! -e "${name}_${version}_${arch}.snap" ]]; then
echo "Could not find ${name}_${version}_${arch}.snap"
Expand Down

0 comments on commit ad6972e

Please sign in to comment.