Chat plugins: support a way to set custom avatars #6666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mia-pi-git
changed the title
mia-pi-git
changed the title
Zarel
force-pushed
the
master
branch
2 times, most recently
from
e75cc47 to
381bd75
Compare
|
I thought this was drafted, but it's possible that it was finished sometime between our incredibly busy phase where I didn't have time to look at it. In any case, it could at least use an update to |
Zarel
reviewed
Jun 15, 2020
|
Superseded by #8563 which is live. |
|
Not completely superseded. There's one more feature I'd expect side servers to want, which is a way to grab an avatar from a URL and put it in |
|
Which this code does provide! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5515, but i deleted my old fork, so i can't just use that PR.
Note for those looking that this is just for side servers.