SSB: Fix null reference error in 'Drifting' ability #10824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a crash caused by a `TypeError` when the `defender` is `null` in the `Drifting` ability. Added necessary null checks in the `onModifyAtk` and `onModifySpA` methods to ensure `defender` is valid before accessing its properties. **Stack Trace:** ```TS A battle crashed: TypeError: Cannot read properties of null (reading 'activeTurns') at Battle.onModifyAtk (/home/ps/main/data/mods/gen9ssb/abilities.ts:1725:18) at Battle.runEvent (/home/ps/main/sim/battle.ts:845:34) at Pokemon.getStat (/home/ps/main/sim/pokemon.ts:602:23) at Battle.onModifyMove (/home/ps/main/data/mods/gen9ssb/moves.ts:6018:16) at Battle.singleEvent (/home/ps/main/sim/battle.ts:585:25) at BattleActions.useMoveInner (/home/ps/main/data/mods/gen9ssb/scripts.ts:1308:16) at BattleActions.useMove (/home/ps/main/sim/battle-actions.ts:386:27) at BattleActions.runMove (/home/ps/main/data/mods/gen9ssb/scripts.ts:1216:34) at Battle.runAction (/home/ps/main/data/mods/gen9ssb/scripts.ts:443:17) at Battle.turnLoop (/home/ps/main/sim/battle.ts:2802:9) ```
|
Huh, why doesn't Stakeout crash all the time for the same reason? I guess nobody ever runs it... |
When |
|
That particular SSB ability also has the effect of Wandering Spirit, which means it can easily find itself swapped onto a user of a move that calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a crash caused by a
TypeErrorwhen thedefenderisnullin theDriftingability.Stack Trace: