RoomGame: Check Game Exists Before Notification #10821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a null check for `this.game` in the `sendRoom` method within `room-game.ts` to prevent a `TypeError` when attempting to access the `roomid` property of a null game object. **Changes:** - Updated `room-game.ts` Line 92 to include a check for `this.game` before sending messages to the room. **Potential Root Cause:** The error likely originates from the order of operations in the UNO game logic within uno.ts. Specifically, room notifications may be sent after modifying the game state (e.g., setting this.game to null or removing a player). This sequence can result in some players having a null game reference when notifications are dispatched, leading to the observed TypeError. Stack Trace: ```JS A chat command crashed: TypeError: Cannot read properties of null (reading 'roomid') at UNOPlayer.sendRoom (/home/ps/main/server/room-game.ts:92:36) at UNO.sendToRoom (/home/ps/main/server/chat-plugins/uno.ts:255:12) at UNO.leaveGame (/home/ps/main/server/chat-plugins/uno.ts:182:9) at CommandContext.leave [as handler] (/home/ps/main/server/chat-plugins/uno.ts:766:14) at CommandContext.run (/home/ps/main/server/chat.ts:712:29) at CommandContext.parse (/home/ps/main/server/chat.ts:610:20) at Object.parse (/home/ps/main/server/chat.ts:1896:26) at User.chat (/home/ps/main/server/users.ts:1461:9) at Object.socketReceive (/home/ps/main/server/users.ts:1739:12) at Object.onSpawn (/home/ps/main/server/sockets.ts:53:11) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a null check for
this.gamein thesendRoommethod withinroom-game.tsto prevent aTypeErrorwhen attempting to access theroomidproperty of a null game object.Changes:
room-game.tsLine 92 to include a check forthis.gamebefore sending messages to the room.Potential Root Cause:
The error likely originates from the order of operations in the UNO game logic within uno.ts. Specifically, room notifications may be sent after modifying the game state (e.g., setting this.game to null or removing a player). This sequence can result in some players having a null game reference when notifications are dispatched, leading to the observed TypeError.
Stack Trace: