-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the feature importance for Decision Tree Classifier #275
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## development #275 +/- ##
===============================================
+ Coverage 44.98% 45.17% +0.18%
===============================================
Files 85 85
Lines 7214 7226 +12
===============================================
+ Hits 3245 3264 +19
+ Misses 3969 3962 -7 ☔ View full report in Codecov by Sentry. |
hi! thanks for the PR. Please follow the guidance about running the linter in CONTRIBUTING. The linter check is failing. |
Hey, thanks for providing the doc. I was aware of that and changed the PR status as "Draft". Let me try to fix the linter today or tomorrow. |
Hey @Mec-iS I have fixed the linter error, and would you like to review the PR? |
Is there anyone else can help review the PR? It has been quite a while. |
Thanks @tushushu ! Sorry I missed the notification for this. |
@Mec-iS Nice working on this PR. |
This PR fixes part 1/3 of #124
Checklist
Current behaviour
So the feature importance cannot be calculated after model is trained.
New expected behaviour
The feature importance can be calculated after model is trained.
Change logs
The feature importance can be calculated after the DecisionTreeClassifier is trained.