core/chains/evm: simpler evm config #16187
Conversation
jmank88
requested review from
AnieeG,
kylesmartin,
a team,
pavel-raykov and
DylanTinianov
as code owners
jmank88
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
|
I see you updated files related to
|
jmank88
requested review from
samsondav,
a team and
MichelleSausa
and removed request for
a team
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
There was a problem hiding this comment.
Renamed without _internal
core/chains/evm/log/helpers_test.go
Outdated
There was a problem hiding this comment.
Actually moved to integration_test.go, but showing diff because I renamed the _internal version.
There was a problem hiding this comment.
This file has a lot of baggage and won't be able to move anywhere as-is. Some of the tests can be simplified (e.g. keystore stuff), but others are using the job pipeline and I don't fully understand why.
| type ChainScoped struct { | ||
| lggr logger.Logger |
There was a problem hiding this comment.
Unused. We could probably simplify further now, by shedding the constructors and using direct isntantiation struct instead.
|
Towards https://smartcontract-it.atlassian.net/browse/CRE-163
This EVM code doesn't really need the full general
AppConfig, and even the one root-level methodEVMRPCEnabled()is just derived from the EVM chains config, so we are able to remove some interfaces and drop package dependencies.