make setup test deterministic

[krehermann]

CRE-233

flaky test fix; introduced yesterday in test setup refactoring

repo'd local within 15 executions consistently

fix was run 50x with no errors

Requires

Supports

[AnieeG]

unrelated to this pr - is this lint check useful? if not, can we exclude that?

[krehermann]

i was surprised by the linter warning. it seems noisy imo

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , lint , SonarQube Scan

1. Consider pre-allocating keys:[Golang Lint (deployment)]

Source of Error:

Golang Lint (deployment)	2025-01-31T23:00:50.6558740Z ##[error]deployment/keystone/changeset/test/registry.go:101:2: Consider pre-allocating `keys` (prealloc)
Golang Lint (deployment)	2025-01-31T23:00:50.6559775Z 	var keys []capabilities_registry.CapabilitiesRegistryNodeOperator
Golang Lint (deployment)	2025-01-31T23:00:50.6560240Z 	^

Why: The linter suggests pre-allocating the keys slice to improve performance by reducing the number of allocations.

Suggested fix: Pre-allocate the keys slice by specifying its length or capacity if it is known beforehand. For example, keys := make([]capabilities_registry.CapabilitiesRegistryNodeOperator, 0, expectedLength).