[TT-1984] Use job distributor in keystone smoke test + FMS change #16169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
core/services/job/models.go
Outdated
| @@ -823,6 +823,79 @@ func (s *GatewaySpec) SetID(value string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // NodeServerConfigPath returns NodeServerConfig.Path or empty string, if not found or it's not a string | |||
| func (s *GatewaySpec) NodeServerConfigPath() string { | |||
| if nsc, ok := s.GatewayConfig["NodeServerConfig"]; ok { | |||
There was a problem hiding this comment.
@Tofel I'd recommend just unmarshaling the config into a struct (I would expect this to already exist somewhere) and then just grabbing what you need from it; same with the function below.
There was a problem hiding this comment.
Okay, I'll use
, didn't know it existed.There was a problem hiding this comment.
well, can't use due to circular imports :/ and I don't want to put that and other types in yet another package to resolve it, I think it should be done in another PR
cedric-cordenier
previously approved these changes
Feb 3, 2025
|
@Tofel I'd also recommend running this by someone who is more familiar with Gateways, eg. @bolekk @justinkaseman |
justinkaseman
previously approved these changes
Feb 3, 2025
Tofel
dismissed stale reviews from justinkaseman and cedric-cordenier
via
57856f9
|
cedric-cordenier
approved these changes
Feb 3, 2025
justinkaseman
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE:
gatewayandstandardcapabilitiesjobs with the FMSKeystone smoke test:
Unclear:
int64, when iterating over untypedGatewayjob spec?