Fix potential unbounded LLO transmit queue #16166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-tex
previously approved these changes
Jan 31, 2025
samsondav
changed the title
samsondav
force-pushed
the
set_initial_metrics
branch
7 times, most recently
from
0f4bb4e to
80ca5cf
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
samsondav
commented
Jan 31, 2025
samsondav
force-pushed
the
set_initial_metrics
branch
from
ed8eb21 to
4ddee6c
Compare
samsondav
changed the title
samsondav
added a commit
that referenced
this pull request
Feb 3, 2025
We have observed unbounded queue growth in production. Not sure of the cause. This PR implements a swathe of measures intended to make queue management more reliable and safe. - Reduces required number of DB connections and reduce overall DB transaction load - Remove duplicate deletion code from server.go and manage everything in the persistence manager - Introduce an application-wide global reaper for last-ditch cleanup effort - Implement delete batching for more reliable and incremental deletion
samsondav
force-pushed
the
set_initial_metrics
branch
from
4ddee6c to
5376160
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
samsondav
added a commit
that referenced
this pull request
Feb 3, 2025
We have observed unbounded queue growth in production. Not sure of the cause. This PR implements a swathe of measures intended to make queue management more reliable and safe. - Reduces required number of DB connections and reduce overall DB transaction load - Remove duplicate deletion code from server.go and manage everything in the persistence manager - Introduce an application-wide global reaper for last-ditch cleanup effort - Implement delete batching for more reliable and incremental deletion
samsondav
force-pushed
the
set_initial_metrics
branch
from
5376160 to
9bec7e0
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
msuchacz-cll
reviewed
Feb 3, 2025
msuchacz-cll
reviewed
Feb 3, 2025
msuchacz-cll
reviewed
Feb 3, 2025
samsondav
added a commit
that referenced
this pull request
Feb 3, 2025
We have observed unbounded queue growth in production. Not sure of the cause. This PR implements a swathe of measures intended to make queue management more reliable and safe. - Reduces required number of DB connections and reduce overall DB transaction load - Remove duplicate deletion code from server.go and manage everything in the persistence manager - Introduce an application-wide global reaper for last-ditch cleanup effort - Implement delete batching for more reliable and incremental deletion
samsondav
changed the title
msuchacz-cll
previously approved these changes
Feb 5, 2025
jmank88
reviewed
Feb 5, 2025
| } else { | ||
| clients := make(map[string]grpc.Client) | ||
| for _, server := range lloCfg.GetServers() { | ||
| var client grpc.Client | ||
| switch r.mercuryCfg.Transmitter().Protocol() { | ||
| case config.MercuryTransmitterProtocolGRPC: | ||
| client = grpc.NewClient(grpc.ClientOpts{ | ||
| Logger: r.lggr, | ||
| Logger: lggr.Named(server.URL), |
There was a problem hiding this comment.
What sort of url? Will it read OK given the names are dot separated?
There was a problem hiding this comment.
Looks like e.g. example.com/ws or 192.0.2.1:2345/foo/bar
The only differentiating factor between servers is the URL, and the logger name needs to be globally unique, so this was the only way I could think of to do it.
There was a problem hiding this comment.
So the logger name needs to be unique in order to report health independently, but for the purposes of just logging there is no technical conflict with sharing the log - what if we added it as a key/val? Would that be clear enough?
Suggested change
| Logger: lggr.Named(server.URL), | |
| Logger: lggr.With("url", server.URL), |
There was a problem hiding this comment.
Suggested change
| Logger: lggr.Named(server.URL), | |
| Logger: lggr.Named(fmt.Sprintf("%q", server.URL)), |
There was a problem hiding this comment.
will do this in a followup
jmank88
previously approved these changes
Feb 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Bugfixes and improvements intended to make queue management more reliable and safe. - Reduces required number of DB connections and reduce overall DB transaction load - Fixes potential for unbounded queue growth - Fixes possibility of OOM trying to load too many records on boot - Remove duplicate deletion code from server.go and manage everything in the persistence manager - Introduce an application-wide global reaper for last-ditch cleanup effort - Implement delete batching for more reliable and incremental deletion - Ensure that records are properly removed on exit
samsondav
force-pushed
the
set_initial_metrics
branch
from
d73a39c to
1222cbb
Compare
jmank88
approved these changes
Feb 5, 2025
|
msuchacz-cll
approved these changes
Feb 5, 2025
bolekk
reviewed
Feb 5, 2025
| continue | ||
| } | ||
| } else { | ||
| t.lggr.Debugw("Reaped stale transmissions", "nDeleted", n) |
There was a problem hiding this comment.
Missing break? If we get here, we're just spinning in the for loop and spamming logs like crazy :)
Also the Reaper gets enabled by default on unrelated DONs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed unbounded queue growth in production. This PR implements a swathe of bugfixes and improvements intended to make queue management more reliable and safe.