Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate MultiNode RPCClientBase with EVM #15925

Merged
merged 37 commits into from
Feb 4, 2025
Merged

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Jan 14, 2025

Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-1071

Integrated MultiNode RPCClientBase with EVM RPCClient. This extracts a lot of chain-agnostic functionality into the base class inside of chainlink-framework, which will be reused across new Multinode chain integrations and simplify the integration process.

Some EVM specific functionality is implemented in SubscribeToHeads and SubscribeToFinalizedHeads, which are used instead of the RPCClientBase defaults methods (which will be used for new MultiNode integrations).

Requires

Create MultiNode RPCClientBase in chainlink-framework

Soak Testing

Arbitrum Sepolia - 3 RPCs
Namespace: soak-ocr-v1-arbitrum-sepolia-6b507

@DylanTinianov DylanTinianov self-assigned this Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@DylanTinianov DylanTinianov changed the title Use multinode adaptor Integrate MultiNode Adaptor with EVM Jan 15, 2025
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and f05b125 (BCFR-1071-multinode-adaptor).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRPCClient_SubscribeToHeads 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/chains/evm/client false 1.04s @smartcontractkit/bix-framework, @smartcontractkit/core
TestRPCClient_SubscribeToHeads/App_layer_observations_are_not_affected_by_new_block_if_health_check_flag_is_present 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/chains/evm/client false 0s @smartcontractkit/bix-framework, @smartcontractkit/core
TestRPCClient_SubscribeToHeads/Updates_chain_info_on_new_blocks 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/chains/evm/client false 0s @smartcontractkit/bix-framework, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@DylanTinianov DylanTinianov marked this pull request as ready for review January 21, 2025 21:52
@DylanTinianov DylanTinianov requested review from a team as code owners January 21, 2025 21:52
core/chains/evm/client/rpc_client.go Outdated Show resolved Hide resolved
core/chains/evm/client/rpc_client.go Outdated Show resolved Hide resolved
core/chains/evm/client/rpc_client.go Outdated Show resolved Hide resolved
core/chains/evm/client/rpc_client.go Outdated Show resolved Hide resolved
pavel-raykov
pavel-raykov previously approved these changes Jan 30, 2025
pavel-raykov
pavel-raykov previously approved these changes Jan 30, 2025
core/scripts/go.mod Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Feb 3, 2025
@DylanTinianov DylanTinianov requested a review from jmank88 February 3, 2025 23:01
@jmank88 jmank88 requested review from krehermann and ilija42 February 3, 2025 23:11
@jmank88 jmank88 enabled auto-merge February 3, 2025 23:12
@jmank88 jmank88 requested a review from samsondav February 3, 2025 23:31
@jmank88 jmank88 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into develop with commit 4fa029f Feb 4, 2025
188 of 189 checks passed
@jmank88 jmank88 deleted the BCFR-1071-multinode-adaptor branch February 4, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants