Solana plugin codec implementation #15816
Merged
+906
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
…NONEVM-935/implement-ccip-solana-plugin-codec
…NONEVM-935/implement-ccip-solana-plugin-codec
| require.NoError(t, err) | ||
|
|
||
| commitCodec := NewCommitPluginCodecV1() | ||
| decode, err := commitCodec.Decode(testutils.Context(t), buf.Bytes()) |
There was a problem hiding this comment.
Could we also do the reverse for the same data?
I mean encode with commitCodec, and then decode with borsch decoder?
| require.NoError(t, err) | ||
|
|
||
| executeCodec := NewExecutePluginCodecV1() | ||
| decode, err := executeCodec.Decode(testutils.Context(t), buf.Bytes()) |
There was a problem hiding this comment.
same reverse comment for execute codec too
prashantkumar1982
approved these changes
Jan 31, 2025
winder
reviewed
Feb 1, 2025
core/scripts/go.mod
Outdated
There was a problem hiding this comment.
These dependency changes seem unintentional
makramkd
approved these changes
Feb 3, 2025
winder
approved these changes
Feb 3, 2025
|
huangzhen1997
merged commit cd78da0
into
solana-offchain-plugin
195 of 197 checks passed
huangzhen1997
deleted the
NONEVM-935/implement-ccip-solana-plugin-codec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira reference:
https://smartcontract-it.atlassian.net/browse/NONEVM-935
The codec is implemented using chainlink-ccip gobinding tool.
The onchain sdk will provide a calculation for the token pool accounts, right now it's a fixed account length based on https://github.com/smartcontractkit/chainlink-ccip/blob/main/chains/solana/contracts/tests/ccip/ccip_router_test.go#L4839