Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the root snooze time config. #547

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use the root snooze time config. #547

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8b9a2b
Use the root snooze time config.
winder Feb 3, 2025
a6fefa8
Merge branch 'main' into will/snooze-3
winder Feb 3, 2025
f935b40
Merge branch 'main' into will/snooze-3
winder Feb 6, 2025
ed78800
Merge branch 'main' into will/snooze-3
winder Feb 6, 2025
275d8de
Merge branch 'main' into will/snooze-3
winder Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion execute/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func NewPlugin(
commitRootsCache: cache.NewCommitRootsCache(
logutil.WithComponent(lggr, "CommitRootsCache"),
offchainCfg.MessageVisibilityInterval.Duration(),
time.Minute*5),
offchainCfg.RootSnoozeTime.Duration()),
}
}

Expand Down
2 changes: 1 addition & 1 deletion pluginconfig/execute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type ExecuteOffchainConfig struct {
// The caching prevents us from issuing another report while one is already in flight.
InflightCacheExpiry commonconfig.Duration `json:"inflightCacheExpiry"`

// RootSnoozeTime is the interval at which we check roots for executable messages.
// RootSnoozeTime is the delay duration used when a commit root is snoozed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this configuration served a different purpose for the OCR2 plugin. Is that old behavior what we want?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @mateusz-sekara

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just a typo, I believe I ported these over last year, could be a copy pasta.

RootSnoozeTime commonconfig.Duration `json:"rootSnoozeTime"`

// MessageVisibilityInterval is the time interval for which the messages are visible by the plugin.
Expand Down
Loading