Introducing ExtendedBatchGetLatestValuesGraceful #546
+264
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnogo
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
|
winder
reviewed
Feb 3, 2025
Comment on lines
+88
to
+93
| // ExtendedBatchGetLatestValuesGraceful performs the same operations as ExtendedBatchGetLatestValues | ||
| // but handles ErrNoBindings gracefully by: | ||
| // 1. Skipping contracts with no bindings instead of returning an error | ||
| // 2. Returning partial results for contracts that do have bindings | ||
| // 3. Including information about which contracts were skipped due to no bindings | ||
| ExtendedBatchGetLatestValuesGraceful( |
There was a problem hiding this comment.
Are we using ExtendedBatchGetLatestValues anywhere? Maybe we can add this functionality to the existing function instead of creating a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed to batch the config call in the ccip reader as some bindings might not be done when we execute the batch call.