-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: example receiver #521
Conversation
e3fc245
to
1b4b1e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not an auto-generated file
this alias file allows resolving the types that are declared in other contracts/packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
56332cf
to
82938f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't leave a full review as I have to stop for today, but wanted to just leave some thoughts on arrayvec
for the time being.
Either way, I'll have to base my offramps auth code in this PR, so I'll be prioritizing reviewing this asap 🙂.
chains/solana/contracts/programs/example-ccip-receiver/src/lib.rs
Outdated
Show resolved
Hide resolved
636cdcb
to
2847314
Compare
ef7cdba
to
76ce883
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor comment fix and an open question on test determinism.
chains/solana/contracts/programs/example-ccip-receiver/src/lib.rs
Outdated
Show resolved
Hide resolved
#[account] | ||
#[derive(InitSpace, Default, Debug)] | ||
pub struct ApprovedSender {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah interesting: Looks like this is a more idiomatic (though of course somewhat awkward for anyone not experienced with Solana) way of implementing an allowlist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha yeah - it's the solana way of unbounded data structures (make it a mappable PDA)
|
test-
prefixexample-ccip-receiver
as templateexample-ccip-receiver
example-ccip-receiver
withtest-ccip-receiver