Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: example receiver #521

Merged
merged 12 commits into from
Feb 3, 2025
Merged

solana: example receiver #521

merged 12 commits into from
Feb 3, 2025

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 commented Jan 29, 2025

  • rename existing receivers with test- prefix
  • create new example-ccip-receiver as template
  • test cases for example-ccip-receiver
  • integrate example-ccip-receiver with test-ccip-receiver

@aalu1418 aalu1418 force-pushed the solana/example-receiver branch from e3fc245 to 1b4b1e0 Compare January 29, 2025 21:32
@aalu1418 aalu1418 marked this pull request as ready for review January 30, 2025 20:19
@aalu1418 aalu1418 requested a review from a team as a code owner January 30, 2025 20:19
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not an auto-generated file
this alias file allows resolving the types that are declared in other contracts/packages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor

@PabloMansanet PabloMansanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't leave a full review as I have to stop for today, but wanted to just leave some thoughts on arrayvec for the time being.

Either way, I'll have to base my offramps auth code in this PR, so I'll be prioritizing reviewing this asap 🙂.

@aalu1418 aalu1418 force-pushed the solana/example-receiver branch from 636cdcb to 2847314 Compare January 31, 2025 20:03
@aalu1418 aalu1418 force-pushed the solana/example-receiver branch from ef7cdba to 76ce883 Compare January 31, 2025 23:58
Copy link
Contributor

@PabloMansanet PabloMansanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor comment fix and an open question on test determinism.

Comment on lines +327 to +329
#[account]
#[derive(InitSpace, Default, Debug)]
pub struct ApprovedSender {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting: Looks like this is a more idiomatic (though of course somewhat awkward for anyone not experienced with Solana) way of implementing an allowlist.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha yeah - it's the solana way of unbounded data structures (make it a mappable PDA)

chains/solana/contracts/tests/examples/receiver_test.go Outdated Show resolved Hide resolved
@aalu1418 aalu1418 enabled auto-merge (squash) February 3, 2025 16:02
Copy link

github-actions bot commented Feb 3, 2025

Metric solana/example-receiver main
Coverage 75.5% 75.4%

@aalu1418 aalu1418 merged commit c7a9e99 into main Feb 3, 2025
17 checks passed
@archseer archseer deleted the solana/example-receiver branch February 4, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants