Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #43

Merged
merged 7 commits into from
Aug 4, 2020
Merged

Add CI #43

merged 7 commits into from
Aug 4, 2020

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Jul 3, 2020

Mostly to fix/test the out-of-the-box scenario (i.e. #39). This PR:

  • Adds Travis CI (and a build badge that will need pointing to here, not my fork, once that gets enabled).
  • Fixes the "ne" case in mappings
  • And FHIRUnitTestItem's use of enum name
  • Adds an exception for null values for plandefinition-example-cardiology-os as that file has that broken data, and I'm guessing that's just fine, right? Updated default download spec to R4 so we have working tests.

See https://travis-ci.org/github/palfrey/fhir-parser/builds/714539338 for working demo build

@palfrey
Copy link
Contributor Author

palfrey commented Aug 3, 2020

@raheelsayeed @p2-apple @jmandel Any thoughts on this one?

@p2-apple
Copy link
Collaborator

p2-apple commented Aug 3, 2020

Instead of hardcoding a workaround for the broken test data, have you tried pointing Default/settings.py to DSTU2 or R4 instead of the May2018 beta build? I'd prefer it if we didn't have to hardcode test data exceptions in the code.

@palfrey
Copy link
Contributor Author

palfrey commented Aug 3, 2020

Instead of hardcoding a workaround for the broken test data, have you tried pointing Default/settings.py to DSTU2 or R4 instead of the May2018 beta build? I'd prefer it if we didn't have to hardcode test data exceptions in the code.

I hadn't, no. I've now set it to default to R4 and it works without the hack.

@p2-apple
Copy link
Collaborator

p2-apple commented Aug 3, 2020

Sweet! Mind deleting the May2018 line entirely? Might confuse others that it may have special meaning but it's just the last that was used.

@palfrey
Copy link
Contributor Author

palfrey commented Aug 4, 2020

Sweet! Mind deleting the May2018 line entirely? Might confuse others that it may have special meaning but it's just the last that was used.

Done

@raheelsayeed raheelsayeed merged commit 5d2945e into smart-on-fhir:master Aug 4, 2020
@palfrey palfrey deleted the travis branch August 4, 2020 20:38
@palfrey palfrey mentioned this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants