-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #43
Add CI #43
Conversation
@raheelsayeed @p2-apple @jmandel Any thoughts on this one? |
Instead of hardcoding a workaround for the broken test data, have you tried pointing Default/settings.py to DSTU2 or R4 instead of the May2018 beta build? I'd prefer it if we didn't have to hardcode test data exceptions in the code. |
I hadn't, no. I've now set it to default to R4 and it works without the hack. |
Sweet! Mind deleting the May2018 line entirely? Might confuse others that it may have special meaning but it's just the last that was used. |
Done |
Mostly to fix/test the out-of-the-box scenario (i.e. #39). This PR:
Adds an exception for null values for plandefinition-example-cardiology-os as that file has that broken data, and I'm guessing that's just fine, right?Updated default download spec to R4 so we have working tests.See https://travis-ci.org/github/palfrey/fhir-parser/builds/714539338 for working demo build