Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is a bug with large zip files and path joining so we need to in… #442

Merged
merged 1 commit into from
Jun 20, 2024
Merged

there is a bug with large zip files and path joining so we need to in… #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions self_hosting_machinery/finetune/scripts/finetune_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import sys
import click
import copy
import json
Expand All @@ -18,7 +17,8 @@
import torch.distributed as dist

from refact_utils.scripts import env
from refact_utils.scripts.env import safe_paths_join
# TODO: there is a bug with large zip files and path joining so we need to investigate it
# from refact_utils.scripts.env import safe_paths_join
from refact_utils.finetune.utils import finetune_train_defaults
from self_hosting_machinery.finetune.configuration.finetune_config import base_config, ConfigBuilder
from self_hosting_machinery.finetune.scripts.auxiliary.dataset import (
Expand Down Expand Up @@ -170,8 +170,8 @@ def gpu_filter_and_build_config(
def _copy_source_files(jsonl_src, jsonl_dst, pname, run_id):
for d in jsonlines.open(jsonl_src):
try:
src_path = safe_paths_join(env.PP_DIR_UNPACKED(pname), d["path"])
dst_path = safe_paths_join(env.PERRUN_DIR_UNPACKED(run_id), d["path"])
src_path = os.path.join(env.PP_DIR_UNPACKED(pname), d["path"])
dst_path = os.path.join(env.PERRUN_DIR_UNPACKED(run_id), d["path"])
except ValueError as e:
raise ValueError(f'copy source files error: {e}')
os.makedirs(os.path.dirname(dst_path), exist_ok=True)
Expand Down